Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1 #4179

Merged
merged 1 commit into from
Dec 26, 2021
Merged

Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1 #4179

merged 1 commit into from
Dec 26, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the NPE occurred when using EnableApolloConfig with Spring 3.1.1

Which issue(s) this PR fixes:

Fixes #4178

Brief changelog

  • Disable namespace placeholder support for Spring version prior to 3.2.x

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam requested a review from Anilople December 25, 2021 03:17
@nobodyiam nobodyiam requested a review from Anilople December 26, 2021 09:04
Anilople
Anilople approved these changes Dec 26, 2021
View reviewed changes
Copy link
Contributor

@Anilople Anilople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anilople Anilople merged commit c47f773 into apolloconfig:1.x Dec 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2021
@nobodyiam nobodyiam deleted the fix-4178 branch December 26, 2021 11:47
@nobodyiam nobodyiam added this to the 1.9.2 milestone Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Anilople Anilople Anilople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nobodyiam @Anilople