-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support search by item #3977
support search by item #3977
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Codecov Report
@@ Coverage Diff @@
## master #3977 +/- ##
============================================
+ Coverage 51.17% 51.21% +0.03%
- Complexity 2494 2500 +6
============================================
Files 481 482 +1
Lines 14723 14776 +53
Branches 1521 1527 +6
============================================
+ Hits 7534 7567 +33
- Misses 6663 6678 +15
- Partials 526 531 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feature looks great! Please find some comments below.
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppService.java
Outdated
Show resolved
Hide resolved
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/service/AppService.java
Outdated
Show resolved
Hide resolved
apollo-biz/src/main/java/com/ctrip/framework/apollo/biz/repository/ItemRepository.java
Outdated
Show resolved
Hide resolved
I have read the CLA Document and I hereby sign the CLA |
4b8f19a
to
a15a278
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
support search by item
step 1 : input item key
step2 : jump to target namespace
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.