Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support search by item #3977

Merged
merged 2 commits into from
Sep 18, 2021
Merged

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Sep 11, 2021

What's the purpose of this PR

support search by item

step 1 : input item key

image

step2 : jump to target namespace

image

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@github-actions
Copy link

github-actions bot commented Sep 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@lepdou lepdou added the area/portal apollo-portal label Sep 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2021

Codecov Report

Merging #3977 (d650ef5) into master (debf749) will increase coverage by 0.03%.
The diff coverage is 63.15%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3977      +/-   ##
============================================
+ Coverage     51.17%   51.21%   +0.03%     
- Complexity     2494     2500       +6     
============================================
  Files           481      482       +1     
  Lines         14723    14776      +53     
  Branches       1521     1527       +6     
============================================
+ Hits           7534     7567      +33     
- Misses         6663     6678      +15     
- Partials        526      531       +5     
Impacted Files Coverage Δ
...o/adminservice/controller/NamespaceController.java 14.70% <0.00%> (-1.43%) ⬇️
...trip/framework/apollo/biz/service/ItemService.java 14.86% <0.00%> (-0.21%) ⬇️
...framework/apollo/biz/service/NamespaceService.java 63.68% <0.00%> (-1.84%) ⬇️
...k/apollo/portal/component/config/PortalConfig.java 24.70% <0.00%> (-0.30%) ⬇️
...mework/apollo/portal/controller/AppController.java 26.82% <0.00%> (+0.94%) ⬆️
...ip/framework/apollo/portal/service/AppService.java 17.80% <ø> (ø)
...mework/apollo/portal/service/NamespaceService.java 67.50% <0.00%> (-0.43%) ⬇️
...p/framework/apollo/portal/api/AdminServiceAPI.java 12.43% <33.33%> (+0.70%) ⬆️
...ork/apollo/portal/controller/SearchController.java 87.17% <87.17%> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update debf749...d650ef5. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature looks great! Please find some comments below.

@lepdou
Copy link
Contributor Author

lepdou commented Sep 16, 2021

I have read the CLA Document and I hereby sign the CLA

@lepdou lepdou force-pushed the dev/lepdou/search_by_item branch from 4b8f19a to a15a278 Compare September 17, 2021 18:04
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 2fb3479 into apolloconfig:master Sep 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2021
@nobodyiam nobodyiam added this to the 1.10.0 milestone Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/portal apollo-portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants