Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dotnet-sdk-user-guide.md #3887

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Conversation

czd890
Copy link
Contributor

@czd890 czd890 commented Aug 11, 2021

Update docs for .NET SDK

What's the purpose of this PR

XXXXX

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

Update docs for .NET SDK
@github-actions
Copy link

github-actions bot commented Aug 11, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@czd890
Copy link
Contributor Author

czd890 commented Aug 11, 2021

I have read the CLA Document and I hereby sign the CLA

@czd890
Copy link
Contributor Author

czd890 commented Aug 11, 2021

recheck

@codecov-commenter
Copy link

Codecov Report

Merging #3887 (95f902b) into master (2e2919d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3887   +/-   ##
=========================================
  Coverage     50.14%   50.14%           
  Complexity     2479     2479           
=========================================
  Files           485      485           
  Lines         14984    14984           
  Branches       1532     1532           
=========================================
  Hits           7514     7514           
  Misses         6938     6938           
  Partials        532      532           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2919d...95f902b. Read the comment docs.

@nobodyiam
Copy link
Member

the current dotnet document was targeted to the old version, I think your change is targeted to the new dotnet-core version?

I guess the dotnet-core version is more popular now, so I'm thinking we may need to add the document for dotnet-core version? How do you think? cc @pengweiqhca

@nobodyiam nobodyiam added this to the 1.10.0 milestone Aug 21, 2021
@Anilople Anilople added the area/document Category issues or prs related to document. label Sep 2, 2021
@pengweiqhca
Copy link
Contributor

I think should merge and then change to dotnet-core.

@pengweiqhca pengweiqhca merged commit e26294f into apolloconfig:master Sep 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/document Category issues or prs related to document.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants