-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2328 #3865
Fix #2328 #3865
Conversation
case: beanDefinition of the bean defined in Configuration annotated class in this case, the `beanDefinition.getBeanClassName()` and `beanClass.getName()` is not match
Codecov Report
@@ Coverage Diff @@
## master #3865 +/- ##
============================================
- Coverage 50.14% 50.11% -0.04%
- Complexity 2464 2465 +1
============================================
Files 483 483
Lines 14919 14925 +6
Branches 1519 1522 +3
============================================
- Hits 7481 7479 -2
- Misses 6910 6917 +7
- Partials 528 529 +1
Continue to review full report at Codecov.
|
Would you please describe an actual case for this issue? |
Spring Boot has a HIGHEST_PRECEDENCE |
Is there a detailed steps to duplicate the issue? I tried the springBootDemo but seems failed to duplicate this issue. |
Hi, just minimal demo generated from https://start.spring.io with apollo-client-config-data dependency
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, please also update the changes.md
@nobodyiam Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
case: beanDefinition of the bean defined in Configuration annotated class
in this case, the
beanDefinition.getBeanClassName()
andbeanClass.getName()
is not matchWhat's the purpose of this PR
XXXXX
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.