Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix show-text-modal.html number display(#3821) #3851

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

CalebZYC
Copy link
Contributor

What's the purpose of this PR

修复整数精度展示问题

Which issue(s) this PR fixes:

Fixes #3821

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@CalebZYC
Copy link
Contributor Author

CalebZYC commented Jul 26, 2021

不好意思,之前合并有问题,重新提了一个pr,麻烦重新revivew一下,谢谢

修改效果如下:
image
image
image
image
image
image
image
image
image

@CalebZYC CalebZYC changed the title fix show-text-modal number display(#3821) fix show-text-modal.html number display(#3821) Jul 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #3851 (9bd17d2) into master (8ccbbe4) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3851   +/-   ##
=========================================
  Coverage     50.16%   50.17%           
- Complexity     2466     2467    +1     
=========================================
  Files           483      483           
  Lines         14921    14921           
  Branches       1520     1520           
=========================================
+ Hits           7485     7486    +1     
  Misses         6909     6909           
+ Partials        527      526    -1     
Impacted Files Coverage Δ
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (-1.18%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-0.61%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ccbbe4...9bd17d2. Read the comment docs.

@JaredTan95 JaredTan95 merged commit 02c43dd into apolloconfig:master Jul 28, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2021
@CalebZYC CalebZYC deleted the issue-3821 branch July 28, 2021 13:00
@nobodyiam nobodyiam added this to the 1.9.0 milestone Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

整数精度展示问题
4 participants