Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use official docker images for manual kubernetes deployment #3840

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Jul 24, 2021

What's the purpose of this PR

Use official docker images for manual kubernetes deployment

Brief changelog

  1. use official docker images
  2. remove unnecessary docker build scripts
  3. remove custom database scripts and let users use standard ones
  4. use built-in default environment names instead of test-alpha and test-beta
  5. adjust default replica to 2
  6. remove init container check as there is no strict requirement of container startup sequence

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@nobodyiam nobodyiam changed the title use official docker images and use built-in default environment names use official docker images for manual kubernetes deployment Jul 24, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2021

Codecov Report

Merging #3840 (8db281e) into master (b2d666f) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3840      +/-   ##
============================================
- Coverage     50.15%   50.13%   -0.03%     
- Complexity     2465     2467       +2     
============================================
  Files           483      483              
  Lines         14921    14921              
  Branches       1520     1520              
============================================
- Hits           7484     7481       -3     
- Misses         6909     6913       +4     
+ Partials        528      527       -1     
Impacted Files Coverage Δ
...mework/apollo/portal/component/PortalSettings.java 57.81% <0.00%> (-7.82%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-0.61%) ⬇️
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) ⬆️
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d666f...8db281e. Read the comment docs.

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 merged commit fa4386f into apolloconfig:master Jul 25, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2021
@nobodyiam nobodyiam deleted the k8s-docker-image branch July 26, 2021 00:59
@nobodyiam nobodyiam added this to the 1.9.0 milestone Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants