-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possiable NPE #3832
Fix possiable NPE #3832
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3832 +/- ##
============================================
- Coverage 50.16% 50.08% -0.08%
+ Complexity 2465 2464 -1
============================================
Files 483 483
Lines 14922 14921 -1
Branches 1520 1520
============================================
- Hits 7485 7473 -12
- Misses 6908 6921 +13
+ Partials 529 527 -2
Continue to review full report at Codecov.
|
Hello, can you briefly explain what scenarios will cause problems? |
Hi, in some edge case, such as debugging for the config loading process, that will be longer than 1 minute, than the log expired and caused the NPE. IMO, also we should keep all logs, it should not too much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nobodyiam ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
NPE in some cases
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.CHANGES
log.