Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possiable NPE #3832

Merged
merged 4 commits into from
Jul 24, 2021
Merged

Fix possiable NPE #3832

merged 4 commits into from
Jul 24, 2021

Conversation

lonre
Copy link
Contributor

@lonre lonre commented Jul 18, 2021

What's the purpose of this PR

NPE in some cases

Which issue(s) this PR fixes:

Fixes #

Brief changelog

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2021

Codecov Report

Merging #3832 (2e18da2) into master (f9c69db) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3832      +/-   ##
============================================
- Coverage     50.16%   50.08%   -0.08%     
+ Complexity     2465     2464       -1     
============================================
  Files           483      483              
  Lines         14922    14921       -1     
  Branches       1520     1520              
============================================
- Hits           7485     7473      -12     
- Misses         6908     6921      +13     
+ Partials        529      527       -2     
Impacted Files Coverage Δ
.../framework/apollo/core/utils/DeferredLogCache.java 71.42% <0.00%> (-0.41%) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
...mework/apollo/portal/component/PortalSettings.java 57.81% <0.00%> (-7.82%) ⬇️
...ervice/service/ReleaseMessageServiceWithCache.java 87.05% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9c69db...2e18da2. Read the comment docs.

@nobodyiam nobodyiam requested a review from klboke July 19, 2021 13:10
@klboke
Copy link
Contributor

klboke commented Jul 20, 2021

Hello, can you briefly explain what scenarios will cause problems?

@lonre
Copy link
Contributor Author

lonre commented Jul 20, 2021

Hello, can you briefly explain what scenarios will cause problems?

Hi, in some edge case, such as debugging for the config loading process, that will be longer than 1 minute,

than the log expired and caused the NPE.

IMO, also we should keep all logs, it should not too much

@klboke

Copy link
Contributor

@klboke klboke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

klboke
klboke previously approved these changes Jul 21, 2021
@lonre
Copy link
Contributor Author

lonre commented Jul 23, 2021

LGTM

@nobodyiam ping

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit b2d666f into apolloconfig:master Jul 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Aug 7, 2021
@lonre lonre deleted the patch-3 branch April 11, 2022 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants