Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: shared session for multi apollo portal #3786

Merged
merged 7 commits into from
Jun 27, 2021

Conversation

vdiskg
Copy link
Contributor

@vdiskg vdiskg commented Jun 24, 2021

What's the purpose of this PR

shared session for multi apollo portal

Which issue(s) this PR fixes:

Fixes #3672

Brief changelog

add spring session support and configure the property spring.session.store-type=none on the application.yml as a default value

How to use

1. No session data-store(dufault)

clear all of the property spring.session.store-type on the properties files(such as application-github.properties), environment variables and system properties

2. Redis backed sessions

configure the properties spring.session.store-type=redis, spring.redis.* on the properties files(such as application-github.properties), environment variables or system properties

3. JDBC backed sessions

configure the properties spring.session.store-type=jdbc, spring.datasource.* on the properties files(such as application-github.properties), environment variables or system properties
configure the property spring.session.jdbc.initialize-schema=always on the properties files(such as application-github.properties), environment variables or system properties to create the table automatically while first time startup and then configure the property spring.session.jdbc.initialize-schema=never

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021

Codecov Report

Merging #3786 (6dd3963) into master (f1eca02) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3786      +/-   ##
============================================
- Coverage     50.10%   50.07%   -0.04%     
+ Complexity     2440     2439       -1     
============================================
  Files           479      479              
  Lines         14810    14810              
  Branches       1504     1504              
============================================
- Hits           7421     7416       -5     
- Misses         6866     6873       +7     
+ Partials        523      521       -2     
Impacted Files Coverage Δ
...work/apollo/biz/message/DatabaseMessageSender.java 50.00% <0.00%> (-14.59%) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.71% <0.00%> (+0.60%) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 85.88% <0.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1eca02...6dd3963. Read the comment docs.

@vdiskg vdiskg requested a review from nobodyiam June 25, 2021 10:27
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit bf80850 into apolloconfig:master Jun 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

原生登录功能,登录成功,刷新就退出了
3 participants