Use queue#take instead of poll #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3765 +/- ##
============================================
- Coverage 50.12% 50.11% -0.02%
+ Complexity 2442 2440 -2
============================================
Files 479 479
Lines 14810 14807 -3
Branches 1504 1503 -1
============================================
- Hits 7423 7420 -3
+ Misses 6866 6865 -1
- Partials 521 522 +1
Continue to review full report at Codecov.
|
|
please update the CHANGES.md |
|
what does |
Technoboy-
changed the title
nobodyiam
reviewed
Jun 23, 2021
CHANGES.md
Outdated
| @@ -46,6 +46,7 @@ Apollo 1.9.0 | |||
| * [feat(apollo-client): add method interestedChangedKeys to ConfigChangeEvent](https://github.com/ctripcorp/apollo/pull/3666) | |||
| * [add More... link for known users](https://github.com/ctripcorp/apollo/pull/3757) | |||
| * [update OIDC documentation](https://github.com/ctripcorp/apollo/pull/3766) | |||
| * [Use queue#take instead of poll to avoid cs](https://github.com/ctripcorp/apollo/pull/3765) | |||
There was a problem hiding this comment.
I noticed you changed the title, we need to also update the description in the changes.md.
btw, does cs mean context switch?
Suggested change
| * [Use queue#take instead of poll to avoid cs](https://github.com/ctripcorp/apollo/pull/3765) | |
| * [Use queue#take instead of poll](https://github.com/ctripcorp/apollo/pull/3765) |
There was a problem hiding this comment.
Yes, so I think it's no need to poll and then sleep.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3764