Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[apollo-configService]: Solve configService startup exception #3679

Merged
merged 19 commits into from
May 18, 2021

Conversation

klboke
Copy link
Contributor

@klboke klboke commented May 12, 2021

What's the purpose of this PR

fix[apollo-configService]: Solve configService startup exception

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2021

Codecov Report

Merging #3679 (b992dfb) into master (d60bf88) will increase coverage by 0.04%.
The diff coverage is 55.55%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3679      +/-   ##
============================================
+ Coverage     50.88%   50.93%   +0.04%     
- Complexity     2327     2331       +4     
============================================
  Files           449      449              
  Lines         14026    14034       +8     
  Branches       1426     1426              
============================================
+ Hits           7137     7148      +11     
+ Misses         6400     6398       -2     
+ Partials        489      488       -1     
Impacted Files Coverage Δ Complexity Δ
...rk/apollo/biz/eureka/ApolloEurekaClientConfig.java 64.28% <55.55%> (-2.39%) 5.00 <3.00> (+3.00) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) 28.00% <0.00%> (-1.00%)
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) 21.00% <0.00%> (+1.00%)
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) 11.00% <0.00%> (+1.00%)
...mework/apollo/portal/component/PortalSettings.java 65.62% <0.00%> (+7.81%) 5.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60bf88...b992dfb. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 15, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klboke
Copy link
Contributor Author

klboke commented May 17, 2021

I have read the CLA Document and I hereby sign the CLA

@klboke
Copy link
Contributor Author

klboke commented May 17, 2021

recheck

@nobodyiam nobodyiam merged commit 1cc8f55 into apolloconfig:master May 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2021
@nobodyiam nobodyiam added this to the 1.9.0 milestone May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants