Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(apollo-client): use assertEquals instead of assertThat #3667

Merged
merged 1 commit into from
May 9, 2021
Merged

test(apollo-client): use assertEquals instead of assertThat #3667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions ...ent/src/test/java/com/ctrip/framework/apollo/internals/LocalFileConfigRepositoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
package com.ctrip.framework.apollo.internals;

import static org.hamcrest.core.IsEqual.equalTo;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
import static org.mockito.Matchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
Expand Down Expand Up @@ -138,9 +136,9 @@ public void testLoadConfigWithNoLocalFile() throws Exception {

Properties result = localFileConfigRepository.getConfig();

assertThat(
assertEquals(
"LocalFileConfigRepository's properties should be the same as fallback repo's when there is no local cache",
result.entrySet(), equalTo(someProperties.entrySet()));
result, someProperties);
assertEquals(someSourceType, localFileConfigRepository.getSourceType());
}

Expand All @@ -159,9 +157,9 @@ public void testLoadConfigWithNoLocalFileMultipleTimes() throws Exception {

Properties anotherProperties = anotherLocalRepoWithNoFallback.getConfig();

assertThat(
assertEquals(
"LocalFileConfigRepository should persist local cache files and return that afterwards",
someProperties.entrySet(), equalTo(anotherProperties.entrySet()));
someProperties, anotherProperties);
assertEquals(someSourceType, localRepo.getSourceType());
}

Expand Down