-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the issue that access key doesn't work if appid passed is in different case #3627
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3627 +/- ##
============================================
+ Coverage 50.97% 50.99% +0.01%
- Complexity 2329 2330 +1
============================================
Files 449 449
Lines 14026 14026
Branches 1426 1426
============================================
+ Hits 7150 7152 +2
+ Misses 6389 6388 -1
+ Partials 487 486 -1
Continue to review full report at Codecov.
|
It looks good to me, but how we avoid this situation next time. |
You are right, there have been several case sensitive issues. Previously we also have this issue for namespace names, and we fixed that via NamespaceUtil#normalizeNamespace. |
@nobodyiam I think we can merge this PR first, and create a new issue to build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
fix the issue that access key doesn't work if appid passed is in different case
Which issue(s) this PR fixes:
Fixes #3626
Brief changelog
Use tree set with CASE_INSENSITIVE_ORDER comparator.
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.