-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3606 #3609
Fixes #3606 #3609
Conversation
@@ -124,6 +124,20 @@ <h5 ng-bind="app.name"></h5> | |||
<!-- bootstrap.js --> | |||
<script src="vendor/bootstrap/js/bootstrap.min.js" type="text/javascript"></script> | |||
|
|||
<script type="application/javascript"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about we use the same code as that in login.html?
<script type="application/javascript">
$(function () {
$.get("prefix-path", function (result) {
window.localStorage.setItem("prefixPath", result);
});
});
</script>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
异步会有加载先后顺序问题,导致prefix-path还未获取,就已经开始加载需要前缀的资源了,从而引起了404问题
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那login.html中的这段代码是否也要做同样的修改?
<script type="application/javascript">
$(function () {
$.get("prefix-path", function (result) {
window.localStorage.setItem("prefixPath", result);
});
});
</script>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试了一下,的确也有上述异步加载问题(会导致zh-CN.json文件404)。又补充提交了 login.html 的修改
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this PR
用来解决portal未启用auth并且配置了context-path后导致的, 访问首页部分资源加载404问题
Which issue(s) this PR fixes:
Fixes #3606
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.