Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3551 and optimize ldap samples #3561

Merged
merged 1 commit into from
Feb 21, 2021

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix the issue that apollo portal won't start when ldap is enabled and optimize ldap samples.

Which issue(s) this PR fixes:

Fixes #3551

Brief changelog

  1. Exclude LdapAutoConfiguration
  2. Simplify ldap configuration samples

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

Codecov Report

Merging #3561 (4f4f20d) into master (8285504) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3561      +/-   ##
============================================
+ Coverage     50.93%   50.95%   +0.02%     
- Complexity     2322     2324       +2     
============================================
  Files           447      447              
  Lines         13989    13989              
  Branches       1423     1423              
============================================
+ Hits           7125     7128       +3     
+ Misses         6374     6373       -1     
+ Partials        490      488       -2     
Impacted Files Coverage Δ Complexity Δ
...rip/framework/apollo/portal/PortalApplication.java 33.33% <ø> (ø) 1.00 <0.00> (ø)
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) 21.00% <0.00%> (+1.00%)
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8285504...4f4f20d. Read the comment docs.

@nobodyiam nobodyiam merged commit 00776a2 into apolloconfig:master Feb 21, 2021
@nobodyiam nobodyiam deleted the fix-3551 branch February 21, 2021 09:32
@nobodyiam nobodyiam added this to the 1.9.0 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

portal1.8.0启用ldap无法启动
2 participants