slim docker images #3530
Closed
slim docker images #3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3530 +/- ##
============================================
+ Coverage 51.32% 51.36% +0.03%
- Complexity 2315 2318 +3
============================================
Files 442 442
Lines 13843 13843
Branches 1408 1408
============================================
+ Hits 7105 7110 +5
+ Misses 6248 6246 -2
+ Partials 490 487 -3
Continue to review full report at Codecov.
|
nobodyiam
requested changes
Feb 6, 2021
There was a problem hiding this comment.
It doesn't work in my environment..
mvn docker:build -pl apollo-adminservice
[INFO] Scanning for projects...
[INFO]
[INFO] -----------< com.ctrip.framework.apollo:apollo-adminservice >-----------
[INFO] Building Apollo AdminService 1.8.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- docker-maven-plugin:1.2.2:build (default-cli) @ apollo-adminservice ---
[INFO] Using authentication suppliers: [ConfigFileRegistryAuthSupplier, FixedRegistryAuthSupplier]
[INFO] Copying /Users/jason/git/mine/apollo/apollo-adminservice/target/apollo-adminservice-1.8.0-SNAPSHOT-github.zip -> /Users/jason/git/mine/apollo/apollo-adminservice/target/docker/apollo-adminservice-1.8.0-SNAPSHOT-github.zip
[INFO] Copying /Users/jason/git/mine/apollo/apollo-adminservice/src/main/docker/Dockerfile -> /Users/jason/git/mine/apollo/apollo-adminservice/target/docker/Dockerfile
[INFO] Building image apolloconfig/apollo-adminservice
[WARNING]: Empty continuation line found in:
RUN echo "http://mirrors.aliyun.com/alpine/v3.8/main" > /etc/apk/repositories && echo "http://mirrors.aliyun.com/alpine/v3.8/community" >> /etc/apk/repositories && apk update upgrade && apk add --no-cache unzip ARG VERSION
[WARNING]: Empty continuation lines will become errors in a future release.
Step 1/14 : FROM openjdk:8-jre-alpine
---> f7a292bbb70c
Step 2/14 : LABEL maintainer="[email protected];ameizi<[email protected]>"
---> Using cache
---> 9414208b4f9a
Step 3/14 : RUN echo "http://mirrors.aliyun.com/alpine/v3.8/main" > /etc/apk/repositories && echo "http://mirrors.aliyun.com/alpine/v3.8/community" >> /etc/apk/repositories && apk update upgrade && apk add --no-cache unzip ARG VERSION
---> Running in ca5cc9b2bf1a
fetch http://mirrors.aliyun.com/alpine/v3.8/main/x86_64/APKINDEX.tar.gz
fetch http://mirrors.aliyun.com/alpine/v3.8/community/x86_64/APKINDEX.tar.gz
v3.8.5-65-g097f0358a9 [http://mirrors.aliyun.com/alpine/v3.8/main]
v3.8.5-37-gf06ffe835a [http://mirrors.aliyun.com/alpine/v3.8/community]
OK: 9616 distinct packages available
fetch http://mirrors.aliyun.com/alpine/v3.8/main/x86_64/APKINDEX.tar.gz
fetch http://mirrors.aliyun.com/alpine/v3.8/community/x86_64/APKINDEX.tar.gz
ERROR: unsatisfiable constraints:
ARG (missing):
required by: world[ARG]
VERSION (missing):
required by: world[VERSION]
| RUN echo "http://mirrors.aliyun.com/alpine/v3.8/main" > /etc/apk/repositories \ | ||
| && echo "http://mirrors.aliyun.com/alpine/v3.8/community" >> /etc/apk/repositories \ | ||
| && apk update upgrade \ | ||
| && apk add --no-cache unzip \ |
There was a problem hiding this comment.
I think we need to remove the trailer \?
Suggested change
| && apk add --no-cache unzip \ | |
| && apk add --no-cache unzip |
There was a problem hiding this comment.
Thanks, please also help to fix the conflicts.
There was a problem hiding this comment.
I had a little problem when trying to fix the conflicts. I refork the repository, and resoved the conflicts, but there is no push notification.
The status in tab of "File Changed" is OK.
Need I create a new PR?
There was a problem hiding this comment.
Maybe there is something wrong during the conflict resolving process, it's ok to create a new pr.
|
recreate PR #3572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
压缩docker镜像大小
Which issue(s) this PR fixes:
Fixes #3527
Brief changelog
压缩docker镜像大小
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.