Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo in helm chart #3336

Merged
merged 3 commits into from
Oct 19, 2020
Merged

fix typo in helm chart #3336

merged 3 commits into from
Oct 19, 2020

Conversation

CoolDarran
Copy link
Contributor

fix indent

nobodyiam
nobodyiam requested changes Oct 18, 2020
View reviewed changes
scripts/helm/apollo-portal/Chart.yaml Outdated Show resolved Hide resolved
scripts/helm/apollo-service/Chart.yaml Outdated Show resolved Hide resolved
nobodyiam
nobodyiam approved these changes Oct 19, 2020
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 13de50b into apolloconfig:master Oct 19, 2020
smilesnake pushed a commit to smilesnake/apollo that referenced this pull request Nov 12, 2020
@CoolDarran @smilesnake
fix typo in helm chart (apolloconfig#3336)
b5c2279
@nobodyiam nobodyiam added this to the 1.8.0 milestone Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@CoolDarran @nobodyiam