fix: fix build.sh warning by shellcheck #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3294 +/- ##
============================================
+ Coverage 51.44% 51.45% +0.01%
- Complexity 2303 2304 +1
============================================
Files 442 442
Lines 13738 13738
Branches 1398 1398
============================================
+ Hits 7067 7069 +2
+ Misses 6180 6179 -1
+ Partials 491 490 -1
Continue to review full report at Codecov.
|
nobodyiam
reviewed
Sep 11, 2020
| @@ -20,7 +20,7 @@ META_SERVERS_OPTS="-Ddev_meta=$dev_meta -Dfat_meta=$fat_meta -Duat_meta=$uat_met | |||
|
|
|||
| # =============== Please do not modify the following content =============== # | |||
| # go to script directory | |||
| cd "${0%/*}" | |||
| cd "${0%/*}" || exit | |||
There was a problem hiding this comment.
Passing parameters is "unstable" and "unsafe"
When an error occurs, just exit,
nobodyiam
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this PR
fix build.sh warning by shellcheck
Which issue(s) this PR fixes:
Fixes #
Brief changelog
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.