-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
添加版本发布触发outgoing webhook notify功能 #3235
Conversation
同步源项目更新内容
Codecov Report
@@ Coverage Diff @@
## master #3235 +/- ##
============================================
- Coverage 51.25% 51.15% -0.10%
- Complexity 2272 2273 +1
============================================
Files 439 440 +1
Lines 13626 13660 +34
Branches 1385 1389 +4
============================================
+ Hits 6984 6988 +4
- Misses 6158 6186 +28
- Partials 484 486 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request, would you please add some explanation as how user could use this webhook? e.g. param description.
Also it looks like the code style is not align with apollo, would you please follow Code Conventions and reformat the changes?
apollo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/WebHookNotify.java
Outdated
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/config/PortalConfig.java
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/portal/component/config/PortalConfig.java
Outdated
Show resolved
Hide resolved
@HuangSheng 麻烦在 PR 的描述中补充一下用户如何使用这个 webhook 功能吧?比如如何启用 webhook、webhook 传递的参数说明等,便于社区中其他用户使用。 |
好的 配置参数:
webhook请求的参数:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@HuangSheng 看了说明,这个通知是全量配置通知吗?是否考虑增量变更合适点? |
这还得自己写个服务端接收这个通知吗?能不能直接支持成钉钉的webhook配置啊? |
你说的这种更方便,直接配置下钉钉的信息就可以发送了。新版的1.8.0有我实现的邮箱通知,就是类似的。钉钉的有需要你可以考虑贡献个,之前时间比较紧就没做钉钉通知 |
config.release.webhook.service.url webhook通知的url地址,需要接收HTTP POST请求。支持多地址,以英文逗号分割。 webhook.supported.envs 支持发送webhook通知的环境列表,英文逗号隔开。 @HuangSheng 你好啊, 非常激动来这里comment, 我用的mariadb 10.3 的数据库 ,默认在ApolloPortalDB.ServerConfig表 没有找到key 为以上两个的 字段, 这两个字段是要自己添加? 还是要用mysql? |
@houbinglei 自己添加即可 |
好的, 非常感谢~ |
麻烦问下这个还需要写后端吗,配置了不起作用呢。 |
What's the purpose of this PR
添加 版本发布触发outgoing webhook notify功能
Which issue(s) this PR fixes:
Fixes #3095
Brief changelog
add webhook notify component
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean test
to make sure this pull request doesn't break anything.