Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the length of AppId from 32 to 64 characters. #3228

Merged
merged 11 commits into from
Aug 14, 2020

Conversation

Ayden-Franklin
Copy link
Contributor

@Ayden-Franklin Ayden-Franklin commented Aug 6, 2020

What's the purpose of this PR

在项目中经常会遇到公司的项目有固定的前缀和格式,项目ID大于32字符的情况,这次扩展为64字符。有其它人也遇到了这个问题,迫切需要扩展这个字段的长度限制。

Which issue(s) this PR fixes:

Fixes #3213

Brief changelog

  1. 把表中AppID字段的长度从32改为64
  2. 把前端javascript中校验规则中32改为64

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2020

Codecov Report

Merging #3228 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3228      +/-   ##
============================================
- Coverage     51.17%   51.16%   -0.02%     
+ Complexity     2275     2274       -1     
============================================
  Files           440      440              
  Lines         13660    13660              
  Branches       1389     1389              
============================================
- Hits           6991     6989       -2     
- Misses         6185     6186       +1     
- Partials        484      485       +1     
Impacted Files Coverage Δ Complexity Δ
.../apollo/internals/RemoteConfigLongPollService.java 77.10% <0.00%> (-1.21%) 28.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a7024...de5ff92. Read the comment docs.

@nobodyiam
Copy link
Member

Please update the ddl for k8s and docker-quick-start.
Also don't forget the delta ddl in flyway and delta folders

Copy link
Contributor Author

@Ayden-Franklin Ayden-Franklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the SQL files for flyway.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 8c5d79f into apolloconfig:master Aug 14, 2020
@Ayden-Franklin Ayden-Franklin deleted the extend_app_id branch August 17, 2020 01:51
@nobodyiam nobodyiam added this to the 1.8.0 milestone Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appId字段长度真的需要超过32个字符
4 participants