Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add context path support and add helm sample #3205

Merged
merged 2 commits into from
Aug 1, 2020

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Jul 25, 2020

What's the purpose of this PR

  1. add context path support
  2. add user defined config files and spring profiles support
  3. add helm sample

Which issue(s) this PR fixes:

Fixes #3201

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2020

Codecov Report

Merging #3205 into master will decrease coverage by 0.04%.
The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3205      +/-   ##
============================================
- Coverage     51.27%   51.22%   -0.05%     
+ Complexity     2274     2272       -2     
============================================
  Files           439      439              
  Lines         13622    13626       +4     
  Branches       1385     1385              
============================================
- Hits           6984     6980       -4     
- Misses         6151     6157       +6     
- Partials        487      489       +2     
Impacted Files Coverage Δ Complexity Δ
...apollo/portal/controller/PrefixPathController.java 50.00% <60.00%> (ø) 1.00 <1.00> (ø)
...rk/apollo/spring/property/SpringValueRegistry.java 83.33% <0.00%> (-5.56%) 10.00% <0.00%> (-1.00%)
...ework/apollo/internals/RemoteConfigRepository.java 86.25% <0.00%> (-3.13%) 24.00% <0.00%> (-1.00%)
.../framework/apollo/spring/property/SpringValue.java 87.71% <0.00%> (-1.76%) 20.00% <0.00%> (-1.00%)
.../apollo/internals/RemoteConfigLongPollService.java 78.31% <0.00%> (+1.20%) 29.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8f3706...af40ac4. Read the comment docs.

@nobodyiam nobodyiam force-pushed the support-context-path branch from 5ed10f2 to 08c2ba5 Compare July 26, 2020 01:11
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jul 26, 2020
@nobodyiam nobodyiam force-pushed the support-context-path branch from 5b4a570 to af40ac4 Compare July 26, 2020 07:40
@nobodyiam nobodyiam merged commit 0173304 into apolloconfig:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在k8s中部署portal,并设置prefix.path不生效
2 participants