Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support extracting placeholder from non-normalized expressions, e.g. ${user.address}/user/gateway #3178

Merged
merged 1 commit into from
Jul 12, 2020

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

support extracting placeholder from non-normalized expressions, e.g. ${user.address}/user/gateway

Which issue(s) this PR fixes:

Fixes #3138 #3169

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@nobodyiam nobodyiam linked an issue Jul 12, 2020 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #3178 into master will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3178      +/-   ##
============================================
+ Coverage     51.53%   51.55%   +0.01%     
- Complexity     2253     2255       +2     
============================================
  Files           433      433              
  Lines         13447    13447              
  Branches       1378     1378              
============================================
+ Hits           6930     6932       +2     
+ Misses         6037     6036       -1     
+ Partials        480      479       -1     
Impacted Files Coverage Δ Complexity Δ
...work/apollo/spring/property/PlaceholderHelper.java 78.46% <0.00%> (-1.54%) 24.00 <5.00> (ø)
.../framework/apollo/spring/property/SpringValue.java 89.47% <0.00%> (+1.75%) 21.00% <0.00%> (+1.00%)
...rk/apollo/spring/property/SpringValueRegistry.java 88.88% <0.00%> (+5.55%) 11.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e0ab3c...8e2452b. Read the comment docs.

@nobodyiam nobodyiam merged commit 0306b71 into apolloconfig:master Jul 12, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants