Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change static version number to ${revision} variable #3151

Merged
merged 1 commit into from
Jul 4, 2020

Conversation

bjo2008cnx
Copy link

What's the purpose of this PR

when the version need to be updated, we need to modify every pom.xml and then commit these files.In this pr, we replace version with {revision} variable so that only one file is required to modify.

Which issue(s) this PR fixes:

Fixes #3134

Brief changelog

1.add property in parent pom.xml
2.replace version number with ${revison} variable
3.add flatten plugin which is needed to replace ${revison} with static version when execute maven commands

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit b901961 into apolloconfig:master Jul 4, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

可否将静态版本号改为 {revision}变量?
2 participants