Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public namespaces only allow properties format #3140

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

public namespaces only allow properties format

Which issue(s) this PR fixes:

Fixes #3119

Brief changelog

check the namespace's isPublic property and set the format to properties if isPublic is true.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-commenter
Copy link

Codecov Report

Merging #3140 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3140   +/-   ##
=========================================
  Coverage     51.24%   51.24%           
- Complexity     2235     2236    +1     
=========================================
  Files           432      432           
  Lines         13425    13427    +2     
  Branches       1381     1382    +1     
=========================================
+ Hits           6879     6881    +2     
  Misses         6068     6068           
  Partials        478      478           
Impacted Files Coverage Δ Complexity Δ
...ork/apollo/portal/service/AppNamespaceService.java 75.55% <100.00%> (+0.55%) 22.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c2c12b...d18d987. Read the comment docs.

@nobodyiam nobodyiam merged commit b4812a6 into apolloconfig:master Jun 21, 2020
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关联了其他应用的public namespce后,拉取不到继承的配置信息
2 participants