Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check namespace permission and retrieve namespace id from db #2973

Merged
merged 1 commit into from
Mar 22, 2020

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

check namespace permission and retrieve namespace id from db

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

Codecov Report

Merging #2973 into master will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2973      +/-   ##
============================================
- Coverage     51.20%   51.19%   -0.02%     
+ Complexity     2229     2228       -1     
============================================
  Files           432      432              
  Lines         13378    13381       +3     
  Branches       1373     1374       +1     
============================================
  Hits           6850     6850              
- Misses         6051     6053       +2     
- Partials        477      478       +1     
Impacted Files Coverage Δ Complexity Δ
...llo/portal/controller/ConfigsExportController.java 8.16% <ø> (ø) 1.00 <0.00> (ø)
...p/framework/apollo/portal/service/ItemService.java 47.87% <50.00%> (-0.27%) 16.00 <0.00> (ø)
...apollo/portal/entity/model/NamespaceTextModel.java 82.60% <0.00%> (-4.35%) 13.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4bac4...ff07e39. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 54.764% when pulling ff07e39 on nobodyiam:misc-change into 9f4bac4 on ctripcorp:master.

@nobodyiam nobodyiam merged commit d64c484 into apolloconfig:master Mar 22, 2020
@nobodyiam nobodyiam deleted the misc-change branch March 22, 2020 11:15
@nobodyiam nobodyiam added this to the 1.7.0 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants