Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a little refactoring for pr #2867 #2930

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

a little refactoring for pr #2867

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #2930 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2930      +/-   ##
============================================
+ Coverage     51.24%   51.24%   +<.01%     
+ Complexity     2218     2217       -1     
============================================
  Files           431      431              
  Lines         13300    13296       -4     
  Branches       1366     1366              
============================================
- Hits           6815     6813       -2     
+ Misses         6009     6007       -2     
  Partials        476      476
Impacted Files Coverage Δ Complexity Δ
...llo/portal/environment/PortalMetaDomainConsts.java 79.68% <100%> (ø) 15 <0> (ø) ⬇️
...o/portal/environment/PortalMetaServerProvider.java 100% <100%> (+5.55%) 9 <5> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b2aa6...dea51d1. Read the comment docs.

@nobodyiam nobodyiam merged commit fba3930 into apolloconfig:master Feb 22, 2020
@nobodyiam nobodyiam added this to the 1.6.0 milestone Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants