Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gray release rule case-insensitive #2928

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Make gray release rule case-insensitive

Which issue(s) this PR fixes:

Fixes #2092

Brief changelog

change grayReleaseRuleCache and reversedGrayReleaseRuleCache to be case insensitive

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

codecov-io commented Feb 22, 2020

Codecov Report

Merging #2928 into master will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2928      +/-   ##
============================================
+ Coverage     51.21%   51.24%   +0.02%     
- Complexity     2216     2218       +2     
============================================
  Files           431      431              
  Lines         13297    13300       +3     
  Branches       1366     1366              
============================================
+ Hits           6810     6815       +5     
+ Misses         6010     6009       -1     
+ Partials        477      476       -1
Impacted Files Coverage Δ Complexity Δ
...work/apollo/common/dto/GrayReleaseRuleItemDTO.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...lo/biz/grayReleaseRule/GrayReleaseRulesHolder.java 72.44% <100%> (+0.44%) 30 <0> (ø) ⬇️
...ollo/biz/grayReleaseRule/GrayReleaseRuleCache.java 87.5% <100%> (+0.54%) 11 <1> (+1) ⬆️
.../apollo/internals/RemoteConfigLongPollService.java 80.72% <0%> (+1.2%) 29% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62cdc90...82555eb. Read the comment docs.

@coveralls
Copy link

coveralls commented Feb 22, 2020

Coverage Status

Coverage increased (+0.02%) to 54.82% when pulling 82555eb on nobodyiam:fix-appid-case into 62cdc90 on ctripcorp:master.

@nobodyiam nobodyiam merged commit ffc33fb into apolloconfig:master Feb 22, 2020
@nobodyiam nobodyiam added this to the 1.6.0 milestone Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appid大小不一致导致不能拉取配置更新
3 participants