Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for java 11 #2888

Merged
merged 1 commit into from
Jan 4, 2020
Merged

fix for java 11 #2888

merged 1 commit into from
Jan 4, 2020

Conversation

nobodyiam
Copy link
Member

@nobodyiam nobodyiam commented Jan 4, 2020

What's the purpose of this PR

Fix the java 11 compatibility issue brought by #2828

Brief changelog

use guava base64 instead of javax.xml.bind.DatatypeConverter to support java 11

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.

@codecov-io
Copy link

codecov-io commented Jan 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fb9b24a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2888   +/-   ##
=========================================
  Coverage          ?   50.69%           
  Complexity        ?     2150           
=========================================
  Files             ?      425           
  Lines             ?    13055           
  Branches          ?     1337           
=========================================
  Hits              ?     6618           
  Misses            ?     5969           
  Partials          ?      468
Impacted Files Coverage Δ Complexity Δ
...framework/apollo/core/signature/HmacSha1Utils.java 62.5% <100%> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb9b24a...79e8400. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 54.278% when pulling 79e8400 on nobodyiam:fix-java-11 into fb9b24a on ctripcorp:master.

@nobodyiam nobodyiam merged commit b718007 into apolloconfig:master Jan 4, 2020
@nobodyiam nobodyiam added this to the 1.6.0 milestone Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants