-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed an issue with openapi item comment being too long。#2823 #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2849 +/- ##
===========================================
- Coverage 50.41% 50.4% -0.02%
Complexity 2083 2083
===========================================
Files 414 414
Lines 12668 12672 +4
Branches 1295 1297 +2
===========================================
Hits 6387 6387
- Misses 5827 5831 +4
Partials 454 454
Continue to review full report at Codecov.
|
Accelerator96
changed the title
Fixed an issue with openapi item comment being too long。
Fixed an issue with openapi item comment being too long。#2823
Dec 17, 2019
JaredTan95
reviewed
Dec 17, 2019
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
nobodyiam
requested changes
Dec 19, 2019
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
...lo-portal/src/main/java/com/ctrip/framework/apollo/openapi/v1/controller/ItemController.java
Outdated
Show resolved
Hide resolved
JaredTan95
approved these changes
Dec 21, 2019
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
通过在openapi的接口中限制item comment的长度。
看了下数据库item表下comment字段能放很长。。
https://github.com/ctripcorp/apollo/blob/ec8ed36479202f35edc1ba7cb6d3ac199040f5d6/scripts/db/migration/configdb/V1.0.0__initialization.sql#L215
但是参考前端的长度限制这里就限制64了。
#2823