Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue with openapi item comment being too long。#2823 #2849

Merged
merged 5 commits into from
Dec 22, 2019
Merged

Fixed an issue with openapi item comment being too long。#2823 #2849

merged 5 commits into from
Dec 22, 2019

Conversation

Accelerator96
Copy link
Contributor

@Accelerator96 Accelerator96 commented Dec 17, 2019

通过在openapi的接口中限制item comment的长度。

看了下数据库item表下comment字段能放很长。。
https://github.com/ctripcorp/apollo/blob/ec8ed36479202f35edc1ba7cb6d3ac199040f5d6/scripts/db/migration/configdb/V1.0.0__initialization.sql#L215
但是参考前端的长度限制这里就限制64了。

#2823

@codecov-io
Copy link

codecov-io commented Dec 17, 2019

Codecov Report

Merging #2849 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #2849      +/-   ##
===========================================
- Coverage     50.41%   50.4%   -0.02%     
  Complexity     2083    2083              
===========================================
  Files           414     414              
  Lines         12668   12672       +4     
  Branches       1295    1297       +2     
===========================================
  Hits           6387    6387              
- Misses         5827    5831       +4     
  Partials        454     454
Impacted Files Coverage Δ Complexity Δ
...k/apollo/openapi/v1/controller/ItemController.java 8.16% <0%> (-0.73%) 1 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce3d70...954cdaf. Read the comment docs.

@coveralls
Copy link

coveralls commented Dec 17, 2019

Coverage Status

Coverage decreased (-0.02%) to 53.985% when pulling 954cdaf on Accelerater:#2823 into 4ce3d70 on ctripcorp:master.

@JaredTan95 JaredTan95 added the bug Categorizes issue or PR as related to a bug. label Dec 17, 2019
@JaredTan95 JaredTan95 added this to the 1.6.0 milestone Dec 17, 2019
@JaredTan95 JaredTan95 added the area/openapi apollo-openapi label Dec 17, 2019
@Accelerator96 Accelerator96 changed the title Fixed an issue with openapi item comment being too long。 Fixed an issue with openapi item comment being too long。#2823 Dec 17, 2019
@nobodyiam nobodyiam merged commit f417ef3 into apolloconfig:master Dec 22, 2019
@Accelerator96 Accelerator96 deleted the #2823 branch March 6, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/openapi apollo-openapi bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants