Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NPE when ReleaseComment is null. #2814

Merged
merged 1 commit into from
Dec 7, 2019
Merged

fix NPE when ReleaseComment is null. #2814

merged 1 commit into from
Dec 7, 2019

Conversation

Accelerator96
Copy link
Contributor

fix ReleaseComment NullPointerException。

@codecov-io
Copy link

codecov-io commented Dec 4, 2019

Codecov Report

Merging #2814 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2814      +/-   ##
============================================
- Coverage     50.48%   50.41%   -0.07%     
+ Complexity     2085     2083       -2     
============================================
  Files           414      414              
  Lines         12668    12668              
  Branches       1294     1295       +1     
============================================
- Hits           6395     6387       -8     
- Misses         5820     5827       +7     
- Partials        453      454       +1
Impacted Files Coverage Δ Complexity Δ
...ponent/emailbuilder/ConfigPublishEmailBuilder.java 1.83% <0%> (ø) 1 <0> (ø) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c5deb7...22d39f5. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 54.002% when pulling 22d39f5 on Accelerater:#2801 into 5c5deb7 on ctripcorp:master.

@JaredTan95 JaredTan95 added the bug Categorizes issue or PR as related to a bug. label Dec 5, 2019
@JaredTan95 JaredTan95 added this to the 1.6.0 milestone Dec 5, 2019
@JaredTan95 JaredTan95 changed the title fix #2801. fix NPE when ReleaseComment is null. Dec 5, 2019
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit b0d169b into apolloconfig:master Dec 7, 2019
@Accelerator96 Accelerator96 deleted the #2801 branch December 17, 2019 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants