Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health check can be simpler #2642

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

sunshanpeng
Copy link
Contributor

the check() method always return 0

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@437026f). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2642   +/-   ##
=========================================
  Coverage          ?   50.24%           
  Complexity        ?     2061           
=========================================
  Files             ?      413           
  Lines             ?    12644           
  Branches          ?     1292           
=========================================
  Hits              ?     6353           
  Misses            ?     5844           
  Partials          ?      447
Impacted Files Coverage Δ Complexity Δ
...lo/configservice/ConfigServiceHealthIndicator.java 100% <100%> (ø) 3 <1> (?)
...ollo/adminservice/AdminServiceHealthIndicator.java 100% <100%> (ø) 3 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 437026f...f3b936a. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 53.785% when pulling d8be1e3 on sunshanpeng:master into f050e44 on ctripcorp:master.

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Previous code also confused to me, but as far as I concerned. The new code looks good to me.

@JaredTan95 JaredTan95 merged commit 95aaa41 into apolloconfig:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants