-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAPI to rollback config. (#2351) #2581
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2581 +/- ##
============================================
- Coverage 50.09% 50.04% -0.05%
Complexity 2047 2047
============================================
Files 412 412
Lines 12586 12594 +8
Branches 1289 1291 +2
============================================
- Hits 6305 6303 -2
- Misses 5834 5843 +9
- Partials 447 448 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, you also need to publish an event to like: com.ctrip.framework.apollo.portal.controller.ReleaseController#rollback---> ConfigPublishEvent?
like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.