Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure the server side's long polling timeout #2532

Merged
merged 6 commits into from
Aug 19, 2019
Merged

configure the server side's long polling timeout #2532

merged 6 commits into from
Aug 19, 2019

Conversation

crecel
Copy link
Contributor

@crecel crecel commented Aug 19, 2019

related pr: #2523

@codecov-io
Copy link

codecov-io commented Aug 19, 2019

Codecov Report

Merging #2532 into master will decrease coverage by 0.02%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2532      +/-   ##
============================================
- Coverage     50.19%   50.16%   -0.03%     
+ Complexity     2046     2045       -1     
============================================
  Files           410      410              
  Lines         12554    12556       +2     
  Branches       1285     1285              
============================================
- Hits           6301     6299       -2     
- Misses         5806     5809       +3     
- Partials        447      448       +1
Impacted Files Coverage Δ Complexity Δ
...m/ctrip/framework/apollo/biz/config/BizConfig.java 31.25% <0%> (-1.36%) 8 <0> (ø)
...o/configservice/wrapper/DeferredResultWrapper.java 100% <100%> (ø) 12 <1> (ø) ⬇️
...igservice/controller/NotificationControllerV2.java 86.2% <100%> (ø) 31 <0> (ø) ⬇️
.../apollo/internals/RemoteConfigLongPollService.java 79.01% <0%> (-1.24%) 27% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb6d7d...98712ee. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 19, 2019

Coverage Status

Coverage decreased (-0.02%) to 53.735% when pulling 98712ee on crecel:crecel-branch into cbb6d7d on ctripcorp:master.

Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredTan95 JaredTan95 merged commit 8eac52e into apolloconfig:master Aug 19, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
* configure server side's long polling timeout

* logical update

* Revert "logical update"

This reverts commit 99943df

* logic uapte
@freshgeek
Copy link

this env is add in apollo server start ? long.polling.timeout

@nobodyiam
Copy link
Member

You may add it in the system config page.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants