DefaultApplicationProvider 在加载/META-INF/app.properties 文件时代码优化 #2515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputStream in = Thread.currentThread().getContextClassLoader().getResourceAsStream(APP_PROPERTIES_CLASSPATH); if (in == null) { in = DefaultApplicationProvider.class.getResourceAsStream(APP_PROPERTIES_CLASSPATH); }
DefaultApplicationProvider 在加载/META-INF/app.properties ,在使用contextClassLoader加载时,应该讲前缀"/"去除,否则加载到的结果为null,只能使用DefaultApplicationProvider.class.进行加载。
修改完成后,运行:
com.ctrip.framework.foundation.internals.provider.DefaultApplicationProviderTest#testLoadAppProperties ,结果OK
具体issue:
#2508