Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改openApi gson解析时间格式报异常问题。 #2462

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

yaningxu
Copy link
Contributor

open api报的解析错误时间格式不对:
xception: Unparseable date: "2019-07-17T19:31:43.686+0800"

Gson gson = (new GsonBuilder()).setDateFormat("yyyy-MM-dd'T'HH:mm:ssZ").create();

yyyy-MM-dd'T'HH:mm:ss.SSSZ(对)
yyyy-MM-dd'T'HH:mm:ssZ(错)

open api报的解析错误时间格式不对:
xception: Unparseable date: "2019-07-17T19:31:43.686+0800"

Gson gson = (new GsonBuilder()).setDateFormat("yyyy-MM-dd'T'HH:mm:ssZ").create();

yyyy-MM-dd'T'HH:mm:ss.SSSZ(对)
yyyy-MM-dd'T'HH:mm:ssZ(错)
@codecov-io
Copy link

Codecov Report

Merging #2462 into master will increase coverage by 8.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2462      +/-   ##
============================================
+ Coverage     50.14%   58.37%   +8.22%     
+ Complexity     2039     1170     -869     
============================================
  Files           408      196     -212     
  Lines         12541     5943    -6598     
  Branches       1281      636     -645     
============================================
- Hits           6289     3469    -2820     
+ Misses         5804     2211    -3593     
+ Partials        448      263     -185
Impacted Files Coverage Δ Complexity Δ
.../portal/spi/configuration/LdapGroupProperties.java
...ework/apollo/portal/controller/ItemController.java
...o/configservice/wrapper/DeferredResultWrapper.java
...omponent/emailbuilder/GrayPublishEmailBuilder.java
...k/apollo/portal/controller/FavoriteController.java
...apollo/portal/entity/vo/AppRolesAssignedUsers.java
...ponent/emailbuilder/NormalPublishEmailBuilder.java
.../framework/apollo/portal/entity/vo/SystemInfo.java
...rk/apollo/portal/service/NamespaceLockService.java
...k/apollo/portal/spi/ctrip/CtripUserInfoHolder.java
... and 202 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebf0ee...7aa948c. Read the comment docs.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit ac28515 into apolloconfig:master Jul 23, 2019
@nobodyiam nobodyiam added this to the 1.5.0 milestone Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants