-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ldap userId with case problem #2326
Conversation
@nobodyiam 帮忙看看有没有问题 |
Codecov Report
@@ Coverage Diff @@
## master #2326 +/- ##
============================================
- Coverage 57.69% 49.88% -7.82%
- Complexity 1130 1991 +861
============================================
Files 196 407 +211
Lines 5943 12457 +6514
Branches 636 1278 +642
============================================
+ Hits 3429 6214 +2785
- Misses 2254 5800 +3546
- Partials 260 443 +183
Continue to review full report at Codecov.
|
改动点有些大,如果只是解决收藏问题的话,是不是只要忽略前端传过来的userId,直接用当前用户的userId就可以了? |
...tal/src/main/java/com/ctrip/framework/apollo/portal/spi/configuration/AuthConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/ctrip/framework/apollo/portal/spi/ldap/ApolloLdapAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
已经修改了 @nobodyiam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix ldap userId with case problem
#2324