Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search app from backend instead of loading all app and filter in frontend #2321

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

nobodyiam
Copy link
Member

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…tend
@nobodyiam nobodyiam requested a review from lepdou June 8, 2019 13:30
@codecov-io
Copy link

codecov-io commented Jun 8, 2019

Codecov Report

Merging #2321 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #2321     +/-   ##
===========================================
- Coverage     50.08%   49.99%   -0.1%     
+ Complexity     1993     1991      -2     
===========================================
  Files           404      404             
  Lines         12422    12429      +7     
  Branches       1275     1275             
===========================================
- Hits           6222     6214      -8     
- Misses         5758     5772     +14     
- Partials        442      443      +1
Impacted Files Coverage Δ Complexity Δ
...ip/framework/apollo/portal/service/AppService.java 16% <0%> (-0.91%) 2 <0> (ø)
...mework/apollo/portal/controller/AppController.java 26.25% <0%> (-1.03%) 3 <0> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa339c...b4e0a62. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 53.56% when pulling b4e0a62 on nobodyiam:search-app into 6aa339c on ctripcorp:master.

@lepdou lepdou merged commit dcc68fb into apolloconfig:master Jun 9, 2019
@nobodyiam nobodyiam added this to the 1.5.0 milestone Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants