Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client's SPI for customizing spring processors' loading #2313

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

liucl
Copy link
Contributor

@liucl liucl commented Jun 5, 2019

exposing 2 SPIs, ConfigPropertySourcesProcessorHelper and ConfigPropertySourcesProcessorHelper, for customizing spring processors's loading. So users can wrap their own client, and easily add their custom spring processors without modifying apollo-client code.

通过SPI 的方式自定义 spring processor 的加载过程 ,方便用户封装自己的客户端时添加自定义的processor,而不用去修改apollo-client中processor加载的代码。

@codecov-io
Copy link

codecov-io commented Jun 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8d82dc1). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2313   +/-   ##
=========================================
  Coverage          ?   50.02%           
  Complexity        ?     1990           
=========================================
  Files             ?      404           
  Lines             ?    12422           
  Branches          ?     1275           
=========================================
  Hits              ?     6214           
  Misses            ?     5765           
  Partials          ?      443
Impacted Files Coverage Δ Complexity Δ
...i/DefaultConfigPropertySourcesProcessorHelper.java 100% <100%> (ø) 4 <4> (?)
.../spring/config/ConfigPropertySourcesProcessor.java 100% <100%> (ø) 2 <1> (?)
...amework/foundation/internals/ServiceBootstrap.java 94.44% <100%> (ø) 6 <3> (?)
...pollo/spring/annotation/ApolloConfigRegistrar.java 100% <100%> (ø) 2 <1> (?)
...spring/spi/DefaultApolloConfigRegistrarHelper.java 100% <100%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d82dc1...806b23c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 53.623% when pulling 6ace144 on liucl:client_spring_extend_point into 89c370e on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is a very goarse grained spi and I'm not sure whether it is useful.

But I think it's ok to merge as the ordered spi is what we want .

@nobodyiam nobodyiam merged commit 0446130 into apolloconfig:master Jun 7, 2019
@liucl liucl deleted the client_spring_extend_point branch June 10, 2019 04:04
@nobodyiam nobodyiam added this to the 1.5.0 milestone Aug 10, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants