-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: https://github.com/ctripcorp/apollo/issues/2111 #2226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2226 +/- ##
============================================
- Coverage 50% 49.94% -0.06%
+ Complexity 1982 1979 -3
============================================
Files 402 402
Lines 12400 12407 +7
Branches 1273 1273
============================================
- Hits 6200 6197 -3
- Misses 5758 5766 +8
- Partials 442 444 +2
Continue to review full report at Codecov.
|
Thanks, will take a detailed look soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The logic looks good to me, however, there are many irrelevant changes, would you please import the apollo code style and update this commit?
ok,i will update the commit with apollo code style!
…---Original---
From: "Jason Song"<notifications@github.com>
Date: Sat, May 18, 2019 19:58 PM
To: "ctripcorp/apollo"<apollo@noreply.github.com>;
Cc: "State change"<state_change@noreply.github.com>;"bkblack"<zh2529414@qq.com>;
Subject: Re: [ctripcorp/apollo] fix: #2111 (#2226)
@nobodyiam requested changes on this pull request.
Thanks! The logic looks good to me, however, there are many irrelevant changes, would you please import the apollo code style and update this commit?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
//1、set deferredResult before check, for avoid more waiting | ||
//If check before set deferredResult and release after check and release before set deferredResult, | ||
//it will wait for more time. | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code block is not necessary, it's also better to remove it.
|
new pr: #2255 |
fix the issue : #2111