Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add txt file format #2181

Merged
merged 1 commit into from
May 1, 2019
Merged

Conversation

nobodyiam
Copy link
Member

Fixes #1953

@codecov-io
Copy link

codecov-io commented May 1, 2019

Codecov Report

Merging #2181 into master will decrease coverage by 0.02%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2181      +/-   ##
============================================
- Coverage     49.95%   49.92%   -0.03%     
- Complexity     1978     1979       +1     
============================================
  Files           401      402       +1     
  Lines         12395    12400       +5     
  Branches       1273     1273              
============================================
- Hits           6192     6191       -1     
- Misses         5761     5765       +4     
- Partials        442      444       +2
Impacted Files Coverage Δ Complexity Δ
...rip/framework/apollo/spi/DefaultConfigFactory.java 91.42% <0%> (-2.69%) 18 <0> (ø)
.../framework/apollo/core/enums/ConfigFileFormat.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...trip/framework/apollo/internals/TxtConfigFile.java 100% <100%> (ø) 2 <2> (?)
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)
.../apollo/internals/RemoteConfigLongPollService.java 79.62% <0%> (-0.62%) 27% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0a567...f21610d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 53.508% when pulling f21610d on nobodyiam:add-txt-format into dd0a567 on ctripcorp:master.

@nobodyiam nobodyiam merged commit a5f5092 into apolloconfig:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

对TXT配置文件的支持
3 participants