Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conflict logical in properties namesapce. #2066

Merged
merged 6 commits into from
Mar 24, 2019
Merged

fix conflict logical in properties namesapce. #2066

merged 6 commits into from
Mar 24, 2019

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Mar 21, 2019

Verify whether to repeat in text mode, when adding properties config.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #2066 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2066      +/-   ##
============================================
+ Coverage     49.99%   50.03%   +0.04%     
- Complexity     1979     1983       +4     
============================================
  Files           401      401              
  Lines         12411    12411              
  Branches       1279     1279              
============================================
+ Hits           6205     6210       +5     
+ Misses         5748     5744       -4     
+ Partials        458      457       -1
Impacted Files Coverage Δ Complexity Δ
...portal/component/txtresolver/PropertyResolver.java 89.53% <100%> (+3.48%) 44 <0> (+2) ⬆️
...mework/apollo/portal/component/PortalSettings.java 65.07% <0%> (-4.77%) 5% <0%> (ø)
...work/apollo/biz/message/DatabaseMessageSender.java 67.34% <0%> (+10.2%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1668fa1...cff4551. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 21, 2019

Coverage Status

Coverage increased (+0.03%) to 53.718% when pulling cff4551 on JaredTan95:property_resolver into 1668fa1 on ctripcorp:master.

@JaredTan95 JaredTan95 changed the title fix conflict logical in properties config. fix conflict logical in properties namesapce. Mar 21, 2019
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 0472150 into apolloconfig:master Mar 24, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
fix conflict logical in properties config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants