Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug (when use reverse proxy with TLS, "HttpServletResponse.sendRe… #1967

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

wkcaeser
Copy link
Contributor

fix bug (when use reverse proxy with TLS, "HttpServletResponse.sendRedirect" will redirect to http rather than https)

…direct" will redirect to http rather than https)
@codecov-io
Copy link

codecov-io commented Feb 15, 2019

Codecov Report

Merging #1967 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1967      +/-   ##
============================================
+ Coverage     50.17%   50.17%   +<.01%     
- Complexity     1978     1979       +1     
============================================
  Files           400      400              
  Lines         12342    12342              
  Branches       1272     1272              
============================================
+ Hits           6192     6193       +1     
  Misses         5691     5691              
+ Partials        459      458       -1
Impacted Files Coverage Δ Complexity Δ
.../apollo/internals/RemoteConfigLongPollService.java 80.36% <0%> (+0.61%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81a1bce...dbdd750. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.889% when pulling dbdd750 on wkcaeser:master into 81a1bce on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants