Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复 spec.template.spec.initContainers[1].name: Duplicate value #1789 #1952

Merged
merged 5 commits into from
Feb 13, 2019

Conversation

wulaiwei
Copy link
Contributor

修改service-apollo-portal-server.yaml

initContainers:
# 确保 admin-service 正常提供服务
- image: alpine-bash:3.8
name: check-service-apollo-admin-server-dev
command: ['bash', '-c', "curl --connect-timeout 2 --max-time 5 --retry 60 --retry-delay 1 --retry-max-time 120 service-apollo-admin-server-dev.sre:8090"]
- image: alpine-bash:3.8
name: check-service-apollo-admin-server-alpha
command: ['bash', '-c', "curl --connect-timeout 2 --max-time 5 --retry 60 --retry-delay 1 --retry-max-time 120 service-apollo-admin-server-test-alpha.sre:8090"]
- image: alpine-bash:3.8
name: check-service-apollo-admin-server-beta
command: ['bash', '-c', "curl --connect-timeout 2 --max-time 5 --retry 60 --retry-delay 1 --retry-max-time 120 service-apollo-admin-server-test-beta.sre:8090"]
- image: alpine-bash:3.8
name: check-service-apollo-admin-server-prod
command: ['bash', '-c', "curl --connect-timeout 2 --max-time 5 --retry 60 --retry-delay 1 --retry-max-time 120 service-apollo-admin-server-prod.sre:8090"]

The Deployment "deployment-apollo-portal-server" is invalid:问题
@codecov-io
Copy link

codecov-io commented Feb 12, 2019

Codecov Report

Merging #1952 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1952   +/-   ##
=========================================
  Coverage     50.86%   50.86%           
  Complexity     1979     1979           
=========================================
  Files           398      398           
  Lines         12175    12175           
  Branches       1249     1249           
=========================================
  Hits           6193     6193           
  Misses         5524     5524           
  Partials        458      458

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8dfb8...7846826. Read the comment docs.

.gitignore Outdated
@@ -25,3 +25,4 @@ target

# git
*.orig
/.vs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the folder for visual studio? maybe it's not necessary for a Java project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉 因为这边使用visual studio 做为编辑器 ,这边已经在.gitignore 移除了与vs相关的内容

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 54.628% when pulling 5b76ff6 on wulaiwei:master into bf1b637 on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 9e479e5 into apolloconfig:master Feb 13, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
…onfig#1789 (apolloconfig#1952)

修复service-apollo-portal-server.yaml initContainers The Deployment "deployment-apollo-portal-server" is invalid:问题
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants