Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rate limter for no app id warning log #1949

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

nobodyiam
Copy link
Member

fixes #1885

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #1949 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1949   +/-   ##
=========================================
  Coverage     50.27%   50.27%           
  Complexity     1928     1928           
=========================================
  Files           396      396           
  Lines         12038    12038           
  Branches       1223     1223           
=========================================
  Hits           6052     6052           
  Misses         5533     5533           
  Partials        453      453

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecfb400...005f445. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 54.028% when pulling 005f445 on nobodyiam:fix-1885 into ecfb400 on ctripcorp:master.

@nobodyiam nobodyiam merged commit c8f84a6 into apolloconfig:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate warn log, is this behaviour expected?
3 participants