Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not allow user to create private app namespace with the same name as some public app namespace #1894

Merged
merged 1 commit into from
Jan 18, 2019

Conversation

nobodyiam
Copy link
Member

fixes #1893

@codecov-io
Copy link

Codecov Report

Merging #1894 into master will increase coverage by 6.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1894      +/-   ##
============================================
+ Coverage      49.9%   56.38%   +6.48%     
+ Complexity     1916     1068     -848     
============================================
  Files           394      191     -203     
  Lines         12057     5799    -6258     
  Branches       1224      606     -618     
============================================
- Hits           6017     3270    -2747     
+ Misses         5590     2274    -3316     
+ Partials        450      255     -195
Impacted Files Coverage Δ Complexity Δ
...ework/apollo/portal/controller/ItemController.java
...o/configservice/wrapper/DeferredResultWrapper.java
...omponent/emailbuilder/GrayPublishEmailBuilder.java
...k/apollo/portal/controller/FavoriteController.java
...apollo/portal/entity/vo/AppRolesAssignedUsers.java
...ponent/emailbuilder/NormalPublishEmailBuilder.java
.../framework/apollo/portal/entity/vo/SystemInfo.java
...rk/apollo/portal/service/NamespaceLockService.java
...k/apollo/portal/spi/ctrip/CtripUserInfoHolder.java
...llo/portal/listener/AppNamespaceDeletionEvent.java
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b794f38...76984a9. Read the comment docs.

@nobodyiam nobodyiam merged commit 96dca9d into apolloconfig:master Jan 18, 2019
@nobodyiam nobodyiam deleted the fix-1893 branch July 20, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like to be a bug of OPS - Namespace?
2 participants