Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support listeners on events based on key patterns. #1461 #1871

Merged
merged 18 commits into from
Jan 20, 2019
Merged

feature: support listeners on events based on key patterns. #1461 #1871

merged 18 commits into from
Jan 20, 2019

Conversation

kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Jan 14, 2019

Fixes #1461 . This patch enables client listeners to interact on events that the key matches a set of patterns. If this patch is acceptable, I'll add some integration tests later and slightly refactor the listener code.

@codecov-io
Copy link

codecov-io commented Jan 14, 2019

Codecov Report

Merging #1871 into master will increase coverage by 0.01%.
The diff coverage is 53.57%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1871      +/-   ##
============================================
+ Coverage     50.22%   50.23%   +0.01%     
- Complexity     1925     1927       +2     
============================================
  Files           394      394              
  Lines         12031    12051      +20     
  Branches       1216     1224       +8     
============================================
+ Hits           6042     6054      +12     
- Misses         5538     5543       +5     
- Partials        451      454       +3
Impacted Files Coverage Δ Complexity Δ
...ip/framework/apollo/mockserver/EmbeddedApollo.java 90.12% <100%> (+2.78%) 18 <0> (+1) ⬆️
...rip/framework/apollo/internals/AbstractConfig.java 78.65% <45%> (-3.21%) 51 <1> (+1)
...o/spring/annotation/ApolloAnnotationProcessor.java 94.11% <60%> (-5.89%) 9 <0> (ø)
...mework/apollo/portal/component/PortalSettings.java 69.84% <0%> (+4.76%) 5% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0776918...aa48bb0. Read the comment docs.

@kezhenxu94
Copy link
Member Author

@nobodyiam Thanks for reviewing, changes are made as requested.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 4fa65a1 into apolloconfig:master Jan 20, 2019
@codingman1990
Copy link

Version 1.4.0 doesn't include this feature, right?

@kezhenxu94
Copy link
Member Author

Version 1.4.0 doesn't include this feature, right?

Included

@codingman1990
Copy link

Version 1.4.0 doesn't include this feature, right?

Included

I mean key-pattern.But i didn't find this from the source that i down from maven repository

@kezhenxu94
Copy link
Member Author

@codingman1990
Copy link

@codingman1990 included, see the release log https://github.com/ctripcorp/apollo/releases

I only see keyprefix but not keypattern.did i do something wrong?I download the source of v1.4.0,it only has keyprefix too.

@kezhenxu94
Copy link
Member Author

@codingman1990 included, see the release log https://github.com/ctripcorp/apollo/releases

I only see keyprefix but not keypattern.did i do something wrong?I download the source of v1.4.0,it only has keyprefix too.

you're right, we only support key prefix now, the title is not updated then, see #1871 (comment)

CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

关于配置变化监听机制的优化建议
4 participants