-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support listeners on events based on key patterns. #1461 #1871
feature: support listeners on events based on key patterns. #1461 #1871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1871 +/- ##
============================================
+ Coverage 50.22% 50.23% +0.01%
- Complexity 1925 1927 +2
============================================
Files 394 394
Lines 12031 12051 +20
Branches 1216 1224 +8
============================================
+ Hits 6042 6054 +12
- Misses 5538 5543 +5
- Partials 451 454 +3
Continue to review full report at Codecov.
|
apollo-client/src/main/java/com/ctrip/framework/apollo/Config.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/Config.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/internals/AbstractConfig.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloConfigChangeListener.java
Outdated
Show resolved
Hide resolved
apollo-client/src/main/java/com/ctrip/framework/apollo/ConfigChangeListener.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
@nobodyiam Thanks for reviewing, changes are made as requested. |
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...nt/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/com/ctrip/framework/apollo/spring/annotation/ApolloConfigChangeListener.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Version 1.4.0 doesn't include this feature, right? |
Included |
I mean key-pattern.But i didn't find this from the source that i down from maven repository |
@codingman1990 included, see the release log https://github.com/ctripcorp/apollo/releases |
I only see keyprefix but not keypattern.did i do something wrong?I download the source of v1.4.0,it only has keyprefix too. |
you're right, we only support key prefix now, the title is not updated then, see #1871 (comment) |
…fig#1461 (apolloconfig#1871) feature: support listeners on events based on key patterns. apolloconfig#1461
Fixes #1461 . This patch enables client listeners to interact on events that the key matches a set of patterns. If this patch is acceptable, I'll add some integration tests later and slightly refactor the listener code.