Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the logic of the 'by-owner' request #1855

Merged
merged 3 commits into from
Jan 13, 2019

Conversation

wkcaeser
Copy link
Contributor

@wkcaeser wkcaeser commented Jan 9, 2019

Fixes #1853

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b76adf9). Click here to learn what that means.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1855   +/-   ##
=========================================
  Coverage          ?   49.83%           
  Complexity        ?     1916           
=========================================
  Files             ?      394           
  Lines             ?    12078           
  Branches          ?     1227           
=========================================
  Hits              ?     6019           
  Misses            ?     5608           
  Partials          ?      451
Impacted Files Coverage Δ Complexity Δ
...mework/apollo/portal/controller/AppController.java 25.58% <0%> (ø) 3 <0> (?)
.../ctrip/framework/apollo/portal/util/RoleUtils.java 66.66% <50%> (ø) 13 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76adf9...be2361c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 52.174% when pulling 81466a2 on wkcaeser:role into 5d15562 on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a good idea.

@nobodyiam nobodyiam merged commit 601e366 into apolloconfig:master Jan 13, 2019
@wkcaeser wkcaeser deleted the role branch January 18, 2019 03:07
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
* change the logic of the 'by-owner' request

* test extractAppIdFromRoleName
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants