Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1841 #1852

Merged
merged 2 commits into from
Jan 13, 2019
Merged

fixes #1841 #1852

merged 2 commits into from
Jan 13, 2019

Conversation

kezhenxu94
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d927552). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1852   +/-   ##
=========================================
  Coverage          ?   49.85%           
  Complexity        ?     1913           
=========================================
  Files             ?      394           
  Lines             ?    12072           
  Branches          ?     1225           
=========================================
  Hits              ?     6018           
  Misses            ?     5607           
  Partials          ?      447
Impacted Files Coverage Δ Complexity Δ
...llo/openapi/client/service/ItemOpenApiService.java 66.27% <ø> (ø) 6 <0> (?)
...k/apollo/openapi/v1/controller/ItemController.java 8.88% <0%> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d927552...a1a5b1c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 52.111% when pulling b712a84 on kezhenxu94:fix/#1841 into 5d15562 on ctripcorp:master.

@nobodyiam
Copy link
Member

Thanks! Will take a detailed look soon!

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit b76adf9 into apolloconfig:master Jan 13, 2019
CrackerCat pushed a commit to CrackerCat/apollo-1 that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants