Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edit config value in fullscreen #1788

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

lepdou
Copy link
Contributor

@lepdou lepdou commented Dec 17, 2018

image

fullscreen mode

image

@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #1788 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1788   +/-   ##
=========================================
  Coverage     48.32%   48.32%           
  Complexity     1913     1913           
=========================================
  Files           394      394           
  Lines         11676    11676           
  Branches       1225     1225           
=========================================
  Hits           5642     5642           
  Misses         5587     5587           
  Partials        447      447

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 152b032...0211a1f. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.15% when pulling 0211a1f on lepdou:edit_fullscreen into 152b032 on ctripcorp:master.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@nobodyiam nobodyiam merged commit 4a294d0 into apolloconfig:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants