-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:import and export configs. #1767
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
===========================================
- Coverage 48.53% 48.33% -0.2%
- Complexity 1910 1913 +3
===========================================
Files 392 394 +2
Lines 11617 11670 +53
Branches 1219 1223 +4
===========================================
+ Hits 5638 5641 +3
- Misses 5531 5582 +51
+ Partials 448 447 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1767 +/- ##
============================================
- Coverage 48.55% 48.32% -0.24%
Complexity 1913 1913
============================================
Files 392 394 +2
Lines 11620 11676 +56
Branches 1219 1225 +6
============================================
Hits 5642 5642
- Misses 5532 5587 +55
- Partials 446 447 +1
Continue to review full report at Codecov.
|
Thanks! Will take a detailed look soon. |
...rtal/src/main/java/com/ctrip/framework/apollo/portal/controller/ConfigsExportController.java
Outdated
Show resolved
Hide resolved
@nobodyiam It seems ci has failed, but it was ok in my local env. I couldn't trigger CI to rerun. Can you rerun it and to check it together? |
I just triggered it manually. Actually you could trigger it by pushing the remote branch again, with a rebase or squash merge. And in this case, since there are 6 commits in one feature branch, I would also suggest you using rebase or squash merge to combine those 6 commits into 1. Would you please help to do so? |
fix check. throw exception. refactoring add known user add known user close InputStream.
fix check. throw exception. refactoring add known user add known user close InputStream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat:import and export configs
add a API for import a config file to namespace and export namespace's configs to file.
But no UI changes.:-P