Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes gray release issue #1677 #1678

Merged
merged 1 commit into from
Nov 18, 2018
Merged

Conversation

nobodyiam
Copy link
Member

Fixes #1677

@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #1678 into master will decrease coverage by 0.07%.
The diff coverage is 61.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1678      +/-   ##
============================================
- Coverage     48.79%   48.71%   -0.08%     
+ Complexity     1911     1908       -3     
============================================
  Files           392      392              
  Lines         11524    11550      +26     
  Branches       1204     1210       +6     
============================================
+ Hits           5623     5627       +4     
- Misses         5465     5480      +15     
- Partials        436      443       +7
Impacted Files Coverage Δ Complexity Δ
...work/apollo/biz/service/ReleaseHistoryService.java 92% <100%> (+0.33%) 6 <1> (+1) ⬆️
...p/framework/apollo/biz/service/ReleaseService.java 72.52% <60.97%> (-4.64%) 41 <4> (-1)
...rk/apollo/internals/DefaultMetaServerProvider.java 55.55% <0%> (-44.45%) 5% <0%> (-4%)
.../apollo/internals/RemoteConfigLongPollService.java 77.91% <0%> (+1.22%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c121a9e...f753bb9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 52.554% when pulling f753bb9 on nobodyiam:fix-1677 into c121a9e on ctripcorp:master.

@nobodyiam nobodyiam merged commit 0ac808d into apolloconfig:master Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants